fix: window check

doczjs · Apr 15, 2019 · cfbda29 · cfbda29
1 parent 8a9b88c
commit cfbda29
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/core/docz-theme-default/src/components/shared/Sidebar/index.tsx b/core/docz-theme-default/src/components/shared/Sidebar/index.tsx
@@ -133,7 +133,7 @@ export const Sidebar: SFC = () => {
   const addOverlayClass = (isHidden: boolean) => {
     const method = !isHidden ? 'add' : 'remove'
 
-    if (window && typeof window !== 'undefined' && !isDesktop) {
+    if (typeof window !== 'undefined' && !isDesktop) {
       document.documentElement!.classList[method]('with-overlay')
     }
   }

diff --git a/core/docz-theme-default/src/components/ui/Playground/index.tsx b/core/docz-theme-default/src/components/ui/Playground/index.tsx
@@ -224,13 +224,13 @@ export const Playground: SFC<PlaygroundProps> = ({
   }, [])
 
   const addUnloadListener = useCallback(() => {
-    if (window && typeof window !== 'undefined') {
+    if (typeof window !== 'undefined') {
       window.addEventListener('beforeunload', unloadListener, false)
     }
   }, [])
 
   const removeUnloadListener = useCallback(() => {
-    if (window && typeof window !== 'undefined') {
+    if (typeof window !== 'undefined') {
       window.removeEventListener('beforeunload', unloadListener, false)
     }
   }, [])
@@ -241,7 +241,7 @@ export const Playground: SFC<PlaygroundProps> = ({
   }, [])
 
   useEffect(() => {
-    if (window && typeof window !== 'undefined') {
+    if (typeof window !== 'undefined') {
       const method = fullscreen ? 'add' : 'remove'
       document.body.classList[method]('with-overlay')
     }

diff --git a/core/docz-theme-default/src/utils/hotkeys.ts b/core/docz-theme-default/src/utils/hotkeys.ts
@@ -3,7 +3,7 @@ import hotkeys from 'hotkeys-js'
 
 export const useHotkeys = (key: string, cb: () => any, inputs?: any[]) => {
   useEffect(() => {
-    if (window && typeof window !== 'undefined') {
+    if (typeof window !== 'undefined') {
       hotkeys(key, cb)
       return () => hotkeys.unbind(key)
     }

diff --git a/core/docz-theme-default/src/utils/storage.ts b/core/docz-theme-default/src/utils/storage.ts
@@ -5,7 +5,7 @@ export class Storage {
   }
 
   public get(): any {
-    if (window && typeof window !== 'undefined') {
+    if (typeof window !== 'undefined') {
       try {
         const item = window.localStorage.getItem(this.name)
         return typeof item === 'string' ? JSON.parse(item) : null
@@ -16,13 +16,13 @@ export class Storage {
   }
 
   public set(value: any): void {
-    if (window && typeof window !== 'undefined') {
+    if (typeof window !== 'undefined') {
       window.localStorage.setItem(this.name, JSON.stringify(value))
     }
   }
 
   public delete(): void {
-    if (window && typeof window !== 'undefined') {
+    if (typeof window !== 'undefined') {
       window.localStorage.removeItem(this.name)
     }
   }

diff --git a/core/docz/src/components/AsyncPlayground.tsx b/core/docz/src/components/AsyncPlayground.tsx
@@ -3,7 +3,7 @@ import loadable from '@loadable/component'
 
 const BasePlayground = loadable(() => import('./Playground'))
 export const Playground: React.SFC<any> = props =>
-  window && typeof window !== 'undefined' ? (
+  typeof window !== 'undefined' ? (
     <React.Suspense fallback={null}>
       <BasePlayground {...props} />
     </React.Suspense>