Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend sidebar to the bottom of the page #609

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

woahitsraj
Copy link

Description

Extends the sidebar on the default theme to the bottom of the page. Previously when scrolling down, the sidebar's background color would not display below the scroll point.

Screenshots

Before After
screen shot 2019-01-25 at 11 12 30 screen shot 2019-01-25 at 11 12 52

@swyxio
Copy link
Contributor

swyxio commented Jan 29, 2019

looks good

@pedronauck pedronauck changed the base branch from dev to v0.14 February 13, 2019 16:04
@pedronauck pedronauck changed the base branch from v0.14 to limbo February 13, 2019 16:06
@pedronauck pedronauck merged commit c1d66e9 into doczjs:limbo Feb 13, 2019
pedronauck added a commit that referenced this pull request Feb 13, 2019
* chore(docz-example-gatsby): add initial structure

* fix(docz-example-gatsby): entry find on layout

* chore: add Link component as prop of theme

* chore: enable eslint on vscode config

* chore: update dependencies

* chore: update dependencies

* fix(docz-core): correct websocket url on template

* chore(docz-core): change entries data format

* chore: some adjusts to fit with gatsby

* feat(docz-example-gatsby): add gatsby poc

* feat(gatsby-theme-docz): add initial version

* fix(gatsby-theme-docz): remove build script

* fix(gatsby-theme-docz): add plugin to compile theme files

* chore: update dependencies

* fix(docz-theme-default): use tippy for tooltip

* chore: update dependencies

* fix(docz-theme-default): add hash on menu heading

* fix(docz): add shouldComponentUpdate for Theme

* fix(gatsby-theme-docz): json parse database

* chore(gatsby-theme-docz): remove some dependency

* fix(docz-theme-default): extend sidebar to the bottom of the page (#609)

* fix(docz-core): public path
@woahitsraj woahitsraj deleted the fix-sidebar branch March 12, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants