Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docz): add window check to useWindowSize hook #669

Merged
merged 1 commit into from
Mar 12, 2019
Merged

fix(docz): add window check to useWindowSize hook #669

merged 1 commit into from
Mar 12, 2019

Conversation

aamorozov
Copy link
Contributor

@aamorozov aamorozov commented Mar 6, 2019 •
edited
Loading

Description

The pr is against v1 branch.

It does the following:

  1. Adds a window check for the case when using on a project with ssr;
  2. Adds a throttleMs argument to pass to the main function(with default left from the original implementation).

The pr is implemented to fix the specific issue with the build step in gatsby, but also remediate any ssr compilation issues due to window object being undefined.

@pedronauck pedronauck merged commit e4d7cb4 into doczjs:v1 Mar 12, 2019
pedronauck added a commit that referenced this pull request Mar 15, 2019
@pedronauck
Merge branch 'v1' of github.com:pedronauck/docz into v1
887d34a 
* 'v1' of github.com:pedronauck/docz:
  fix(docz-core): initialize config state on data server start (#678)
  fix(docz): add window check to useWindowSize hook (#669)
  fix(docz-theme-default): toggle active links on location change (#666)
  fix(gatsby-theme-docz): use options from gatsby-config (#665)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedronauck pedronauck pedronauck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aamorozov @pedronauck