Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IframeWrapper in Playground breaks styled-component render #984

Closed
marcuslindfeldt opened this issue Jul 28, 2019 · 2 comments
Closed

IframeWrapper in Playground breaks styled-component render #984

marcuslindfeldt opened this issue Jul 28, 2019 · 2 comments
Labels
bug Something isn't working pending-release Issue fixed but not published to npm yet v2

Comments

@marcuslindfeldt
Copy link

Bug Report

The IframeWrapper in the Playground does not copy over all styled-components generated styles.

When using conditional styles like the following:

    <Avatar {...props}>
      {imageSrc ? (
        <Image alt={`${name} avatar`} src={imageSrc}  />
      ) : (
        <Initials>{getInitals(name)}</Initials>
      )}
    </Avatar>

the styles for Image and Initials will not be applied.

The styles are injected to the main html document but not to the iframe.

@switz
Copy link

switz commented Jul 31, 2019

Yeah, also seeing this, but only after hot-reloads. Initially styles are there, but on hot reloads only the main html doc gets style updates.

@rakannimer
Copy link
Contributor

Thanks for reporting !

It should be fixed with 2.0.0-rc.8, please feel free to re-open or open a new issue if it's not resolved !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending-release Issue fixed but not published to npm yet v2
Projects
None yet
Development

No branches or pull requests

3 participants