Skip to content

Commit

Permalink
fix: Wrong rule configurations (#49)
Browse files Browse the repository at this point in the history
- import/no-restricted-paths was configured the wrong way
- test tests config needed to be updated after babel plugin changes
  • Loading branch information
jhnns authored Aug 31, 2018
1 parent 4cd5e7e commit 58da102
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
8 changes: 4 additions & 4 deletions base.js
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ module.exports = {
target: "./app/server",
},
{
from: "./app",
target: "./test",
from: "./test",
target: "./app",
},
{
from: "./src/server",
Expand All @@ -212,8 +212,8 @@ module.exports = {
target: "./src/server",
},
{
from: "./src",
target: "./test",
from: "./test",
target: "./src",
},
],
},
Expand Down
8 changes: 3 additions & 5 deletions tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,18 @@ module.exports = {
},
rules: {
/* eslint-enable sort-keys */
// chai uses these as assertions
"babel/no-unused-expressions": "off",
// In order to make mocks more condensed, single line blocks are allowed in tests
"brace-style": ["error", "1tbs", { allowSingleLine: true }],
// mocha blocks are nested all the way down
"max-nested-callbacks": "off",
// Can increase the readability of a test if simple mocking functions are in one line
"max-statements-per-line": ["error", { max: 2 }],
// Allows empty catch blocks in try clauses
"no-empty": "error",
"no-empty": "off",
// If you want to test for thrown errors in a constructor function, it's common to ignore the result
// @see https://github.com/peerigon/clockodo/pull/1#discussion_r180795825
"no-new": "off",
// Sometimes it's necessary to check for undefined explicitly
"no-undefined": "off",
// chai uses these as assertions
"no-unused-expressions": "off",
}
};

0 comments on commit 58da102

Please sign in to comment.