-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large angular 5.1 project, IE11 hangs at load. Without parse-domain, loads fine. #29
Comments
Changing to tldjs npm package fixes the problem for us! Our
|
Same issue in a Vue app. The problem is that parseDomain main function returns an es6 object literal with shorthand syntax.
This is unsupported in es5 and honestly shouldn't be shipped untranspiled. |
The spinner was probably due to parsing issues with large regexes. The ES6 problem should be fixed with |
We have a large-ish angular 5.1 project. When parseDomain is included like this:
Then IE11 (11.64.16299.0 with update version 11.0.48) will not load our app.
Instead the app sits at the loading spinner we have for it.
No console output, and no breakpoint (Break on Unhandled Exceptions is chosen)
If I comment out this, then IE11 can load our app.
This code is not even run at startup, but on a button click, so I expect it's causing Angular-cli to suck in the
parse-domain
libraryAny ideas? Do you know an alternate way to strip a host/subdomain, or to match a tld? (it's not simple, as you no doubt know).
I need to make the following kind of transformation:
angular-cli
package.json
has:polyfills.ts
isThe text was updated successfully, but these errors were encountered: