Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several parsing issues #49

Closed
7c opened this issue Sep 16, 2018 · 5 comments
Closed

several parsing issues #49

7c opened this issue Sep 16, 2018 · 5 comments
Labels

Comments

@7c
Copy link

7c commented Sep 16, 2018

While working with live squid logs and parsing i came across following issues:

ftp://mapasamazonsa.com.ve/ > null  ## maybe problem with ftp ?
http://y399.3466633.be:4/235222/399.html > null ## maybe problem with the port 4 ?
this%20file%20was% > crash with 'TypeError: Cannot read property '3' of null'

i wanted give you valid and should-be-working data.

@7c
Copy link
Author

7c commented Sep 18, 2018

Adding several more in order to add my 2cents to improve your repo:

wss://ie14.zopim.com/s/W/ws/zPYsGUAnWMyJ1XOL/c/1537265376519
wss://mp.sparkchess.com/ 
wss://119.92.223.221.prod.hosts.ooklaserver.net:8080/ws
wss://gscspeedtest1.dctechmicro.com.prod.hosts.ooklaserver.net:8080/ws
ws://lhg2-speedtest.globe.com.ph:8080/ws
wss://s-usc1c-nss-218.firebaseio.com/.ws

@7c
Copy link
Author

7c commented Sep 27, 2018

Another one seems to have trouble with a dot at the end of the domain, which is from dns and browser perspective a valid host;

http://server.dr.pt./ > null

@7c
Copy link
Author

7c commented Oct 12, 2018

Afaik the - is not allowed as last char:
{ tld: 'zip', domain: '7-1674-', subdomain: '' }

@jhnns
Copy link
Member

jhnns commented Oct 19, 2018

Thanks for reporting these. I'll switch to an URL instance created by the WHATWG URL constructor in one of the next breaking changes.

@jhnns jhnns closed this as completed in 9f38492 Apr 23, 2020
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants