Native promises #26
Merged
Native promises #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: updates node version to v8.0.0
meaku
reviewed
Jul 19, 2018
lib/request.js
Outdated
| let err; | ||
|
|
||
| if (res.statusCode >= 300) { | ||
| err = new Error("Response with status code: " + res.statusCode); | ||
| err.statusCode = res.statusCode; | ||
| throw err; | ||
| reject(err); | ||
| } else { |
There was a problem hiding this comment.
I personally prefer something like the following to reduce braces, but it's up to you.
if(res.statusCode >= 300){
reject(err);
return;
}
resolve(body);
lib/request.js
Outdated
| return nodefn.call(doRequest, config) | ||
| .spread((res, body) => { | ||
| return new Promise((resolve, reject) => { | ||
| doRequest(config, (res, body) => { |
There was a problem hiding this comment.
I was wondering if there is an error argument as well? What happens if request messes up really badly and won't even return a valid res at all?
.travis.yml
Outdated
| @@ -1,6 +1,8 @@ | |||
| language: node_js | |||
| node_js: | |||
| - "6" | |||
There was a problem hiding this comment.
We have to remove version 6 here.
|
antosan
requested changes
Aug 2, 2018
|
@antosan Can you take another look? |
Closed
antosan
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements native promises (both explicitly and with promisify). Refactors to remove When.js and lodash. Updates node version to v8.0.0. Addresses issue #13