[GRPH 92] Build optimization #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladcow
force-pushed
the
feature/GRPH-92
branch
from
6d6b7d9
to
72d6442
Compare
|
Any upgrades on this one ? If applied correctly it is a great improvement in the build time. |
|
Another good one that we could consider as optimization to do in the future is IMO bitshares/bitshares-core#1737 |
|
I need to update this PR to the actual |
gladcow
changed the title
gladcow
force-pushed
the
feature/GRPH-92
branch
from
72d6442
to
25458c2
Compare
gladcow
changed the title
|
Getting build error with the last version, please check: https://github.com/oxarbitrage/logs/blob/master/peerplays_pull137_build.txt |
|
@oxarbitrage , I've fixed the issue, re-review, please |
oxarbitrage
approved these changes
Dec 3, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of the bitshares/bitshares-core#1768
QA notes: this pull request doesn't change the code behavior, so all tests should pass as before.