Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.0.1 dropped support for Node 18 #495

Closed
caugner opened this issue Feb 26, 2024 · 3 comments · Fixed by #496
Closed

4.0.1 dropped support for Node 18 #495

caugner opened this issue Feb 26, 2024 · 3 comments · Fixed by #496

Comments

@caugner
Copy link

caugner commented Feb 26, 2024

peggy itself requires Node >=18, but 4.0.1 added a dependency on @peggyjs/from-mem in #480, which requires Node >=20.8, effectively introducing a breaking change.
@hildjj
Copy link
Contributor

hildjj commented Feb 26, 2024

Nod, will fix. Parts of from-mem require 20.8, but not all of it. It does a runtime check and throws an error, so I think it's safe to change the min version on from-mem back to 18.

@hildjj
Copy link
Contributor

hildjj commented Feb 26, 2024

See peggyjs/from-mem#8

This was referenced Feb 26, 2024
Merged
Merged
@hildjj
Copy link
Contributor

hildjj commented Feb 26, 2024

Fixed in 4.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dependencies, including latest from-mem hildjj/peggy
2 participants
@hildjj @caugner