New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trailing commas #2

Closed

hildjj opened this issue May 22, 2021 · 1 comment · Fixed by #6

Contributor

hildjj commented May 22, 2021

Decide if they're good or bad, and add a lint rule to enforce consistency.

I don't have a strong opinion, but have prevented them in the past. As a data point the node project recently switched to requiring them.

hildjj mentioned this issue

Better handling of reserved words + ability to redefine them + Plugins API doc peggyjs/peggy#150

Merged

Member

Mingun commented May 23, 2021

I think, that trailing commas are better, because they existence simplify diffs when you add something to the end of list

hildjj mentioned this issue

Merged

hildjj closed this as completed in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment