Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra code for SubxtClient for integration tests #420

Open
ebma opened this issue Oct 13, 2023 · 7 comments · May be fixed by #450
Open

Remove extra code for SubxtClient for integration tests #420

ebma opened this issue Oct 13, 2023 · 7 comments · May be fixed by #450
Labels
priority:low Do it some day

Comments

@ebma
Copy link
Member

ebma commented Oct 13, 2023

We should be able to remove the extra code for the client we have for the vault's integration tests. It's favorable to remove this code if we can to simplify the setup of the integration tests.

For reference, have a look at this setup of the integration tests.
@ebma ebma added the priority:low Do it some day label Oct 13, 2023
@ebma
Copy link
Member Author

ebma commented Oct 13, 2023

@pendulum-chain/product this ticket is just about some refactorings. It is merely nice to have and not required for anything. Thus, it's of rather low priority.

@annatekl
Copy link

Hey team! Please add your planning poker estimate with Zenhub @adelarja @b-yap @ebma @gianfra-t @TorstenStueber

@prayagd
Copy link
Collaborator

prayagd commented Oct 26, 2023

@b-yap are you working on this? should i move this to ready or development?

@ebma
Copy link
Member Author

ebma commented Oct 26, 2023 •
edited
Loading

@b-yap asked to be assigned to some of the low-prio refactoring tickets because she is most suited to work on them. But they are not in development yet. Just treat them as if they were not assigned to anyone.

@prayagd
Copy link
Collaborator

prayagd commented Oct 26, 2023

Thanks Marcel, will move it to bottom in ready column

@b-yap b-yap linked a pull request Nov 21, 2023 that will close this issue
Draft
@prayagd
Copy link
Collaborator

prayagd commented Mar 14, 2024

@b-yap what's the status here? hasnt been updated since nov '23 should we close or icebox it?

@b-yap
Copy link
Contributor

b-yap commented Apr 2, 2024 •
edited
Loading

@prayagd working on this again.
@prayagd yes please, we should icebox this. There's more issues to do, and this is not as urgent.

@b-yap b-yap removed their assignment Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:low Do it some day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

420 remove subxtclient pendulum-chain/spacewalk
4 participants
@b-yap @ebma @prayagd @annatekl