Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README incorrectly claims that nightly rust is needed #572

Open
rursprung opened this issue Nov 18, 2024 · 0 comments
Open

README incorrectly claims that nightly rust is needed #572

rursprung opened this issue Nov 18, 2024 · 0 comments

Comments

@rursprung
Copy link

the README claims that nightly rust is needed to compile the crate:

statime/README.md

Lines 28 to 30 in 942ccaf

## Rust version
Statime requires a nigthly version of cargo/rust. The easiest way to obtain these is through [rustup](https://rustup.rs)

however, this does not seem to be the case as it compiles fine with rust 1.82 (and probably earlier). the only usage of a nightly feature i can see in this repo is TAIT in the statime-stm32
#![feature(type_alias_impl_trait)]

this is also proven by the fact that the CI uses stable rust (only statime-stm32 has a rust-toolchain.toml, so for the others it picks stable):

toolchain: stable

thus i think this can either be completely removed from the README or at least reworded to clearly state that it only applies to statime-stm32 (and in that case the typo in the word nigthly should be fixed as well to make Ctrl+F easier 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant