Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My test results are as shown in the figure. It feels like the value overflows. How can I solve this problem? #3

Open
carfei opened this issue Mar 10, 2020 · 5 comments

Comments

@carfei
Copy link

carfei commented Mar 10, 2020

portrait_o2
portrait_o3
portrait_o4
portrait_o6
My test results are as shown in the figure. It feels like the value overflows. How can I solve this problem?Thanks!

@pengbo-learn
Copy link
Owner

portrait_o2
portrait_o3
portrait_o4
portrait_o6
My test results are as shown in the figure. It feels like the value overflows. How can I solve this problem?Thanks!

The relighting algorithm combines (colors, 3d-vertices, normals) as features, you can try to use colors alone as features and check the results, which should works independent of the 3d reconstruction process.

@carfei
Copy link
Author

carfei commented Mar 12, 2020 via email

@pengbo-learn
Copy link
Owner

Thank you for your reply. I have reorganized and calculated the three features of the color, 3d-vertices, and normals separately, but it is still the wrong result before. The error results are the same when there are the color characteristics. I don't understand the code that you put on git to modify those color parameters, which caused me to have such error results. I hope to hear your answer, thank you! At 2020-03-11 22:16:20, "PengBo" notifications@github.com wrote: My test results are as shown in the figure. It feels like the value overflows. How can I solve this problem?Thanks! The relighting algorithm combines (colors, 3d-vertices, normals) as features, you can try to use colors alone as features and check the results, which should works independent of the 3d reconstruction process. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

"I don't understand the code that you put on git to modify those color parameters, which caused me to have such error results".
You could paste the lines of code which is confusing so we can discuss better.
The colors are normalized to [0, 1], relighted, constrained to [0, 1], then transformed back to [0, 255].

@carfei
Copy link
Author

carfei commented Mar 13, 2020 via email

@fantasy-fish
Copy link

Try to change the line
out_colors = (out_colors*255).astype('uint8')
to
out_colors = (out_colors*255).astype('float')

The problem comes from numeric overflow of the 'uint8' data type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants