feat(theme): add custom height support for the navbar logo #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修正logo高度未使用预定义设置（--vp-nav-logo-height），造成logo高度无法被覆写修改的问题。
✅ Deploy Preview for vuepress-theme-plume ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vuepress-plugin-plume ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pengzhanbo
reviewed
Jul 19, 2024
| @@ -51,7 +51,7 @@ const routeLocale = useRouteLocale() | |||
| } | |||
|
|
|||
| :deep(.logo) { | |||
| height: 24px; | |||
| height: var(--vp-nav-logo-height); | |||
There was a problem hiding this comment.
这里的 css变量 应该添加默认值， var(--vp-nav-logo-height, 24px)
pengzhanbo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修正logo高度未使用预定义设置（--vp-nav-logo-height），造成logo高度无法被覆写修改的问题。