Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom data links for images #297

Closed
dompie opened this issue May 28, 2024 · 1 comment
Closed

Custom data links for images #297

dompie opened this issue May 28, 2024 · 1 comment

Comments

@dompie
Copy link
Contributor

dompie commented May 28, 2024

Hello,

some issues have been fixed with ticket #296 when using custom data in Block mode. Nevertheless a part of my newsletter looks now like this:

screeny2

person1-alt

This is a single image inserted. I used {{contact.data.person1.previewPhotoUrl}} as image URL. The alt text was hardcoded just person1-alt. Image was not linked and no caption added. The e-mail source looks like: [...]<img =src=3D"{{contact.data.person1.previewPhotoUrl}}"[...]

video2-alt

This time I put image information from custom data inside a block's left column (similar to person1-alt). Not linked, no caption. In the source this looks like: [...]<img =src=3D"{{contact.data.video2.previewPhotoUrl}}"[...]

video3-alt

This is an image (similar to pervious images) but this time I used caption and linked it (hard coded, not from custom data). In the source of the e-mail I still see the following src for the image: [...]<img =src=3D"{{contact.data.video3.previewPhotoUrl}}" [...]

So no matter where/how the image was used, custom data is not resolved for image URLs. Can this also be fixed?

@wmnnd
Copy link
Contributor

wmnnd commented May 28, 2024

Thanks for reporting this! This should now be resolved with 2f88371. 0.14.7 is building right now 😊

@wmnnd wmnnd closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants