Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuild support #1

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Protobuild support #1

merged 7 commits into from
Dec 15, 2023

Conversation

grod220
Copy link

@grod220 grod220 commented Dec 9, 2023

Addresses: cosmos#165

Original attempt does not seem to implement protojson like we expected: cosmos#95

Note:

  • Some types needed to be excluded given they depend on tendermint-proto which also does not implement protojson.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main thing to review

@grod220
Copy link
Author

grod220 commented Dec 9, 2023

@avahowell @hdevalence the core of this fixes our issues. Would be helpful to pair on some snags with tendermint proto. Maybe monday? 🍐

@grod220 grod220 force-pushed the protobuild-support branch 2 times, most recently from b576d68 to 988584b Compare December 13, 2023 01:44
@grod220 grod220 marked this pull request as ready for review December 13, 2023 02:05
Copy link
Member

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

@grod220 grod220 merged commit 407a894 into main Dec 15, 2023
10 checks passed
@grod220 grod220 deleted the protobuild-support branch December 15, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants