Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIv2 Library Designs — Tracking List #1937

Open
10 of 71 tasks
smmhrdmn opened this issue Dec 7, 2024 · 6 comments
Open
10 of 71 tasks

UIv2 Library Designs — Tracking List #1937

smmhrdmn opened this issue Dec 7, 2024 · 6 comments

Comments

@smmhrdmn
Copy link

smmhrdmn commented Dec 7, 2024

Is your feature request related to a problem? Please describe.
New ui designs need to be implemented so minifront can be updated and others can utilize the library.

Describe the solution you'd like
Call the current state of the UIv2 Library done, and begin implementing changes. This tracking list can be used to mark off components that have been fully implemented into the ui library. As components are implemented or issues are created from here, please make note of them here.

Describe alternatives you've considered
n/a

Additional context

  • UIv2 Library designs
  • Further details on what changes have been made to each component are outlined in Figma. Some of these changes are minor and some are major. If you have any questions about changes, or run into any issues, please reach out.

Primitives (ready for dev)

Semantics (ready for dev)

Components (ready for dev)

  • Account selector
  • Action Views — (new component) (actions ranked P1 highest priority to P4 lowest priority)
    • SpendView (P1)
    • OutputView (P1)
    • SwapView (P1)
    • SwapClaimView (P1)
    • DelegatorVoteView (P3)
    • ValidatorDefinition (P3)
    • IbcRelay (P1)
    • ProposalSubmit (P3)
    • ProposalWithdraw (P3)
    • ValidatorVote (P3)
    • ProposalDepositClaim (P3)
    • PositionOpen (P1)
    • PositionClose (P1)
    • PositionWithdraw (P1)
    • Delegate (P2)
    • Undelegate (P2)
    • CommunityPoolSpend (P4)
    • CommunityPoolOutput (P4)
    • CommunityPoolDeposit (P4)
    • ActionDutchAuctionScheduleView (P2)
    • ActionDutchAuctionEnd (P2)
    • ActionDutchAuctionWithdrawView (P2)
    • UndelegateClaim (P2)
    • Ics20Withdraw (P1)
  • Address view (feat(ui): updates for address view  #1941)
  • Alert — (new component)
  • Asset Icon — (no changes)
  • Asset Group — (new component)
  • Asset Selector
  • Asset Value Input
  • Auction Routing
  • Block sync bar
  • Block sync popover
  • Button (feat(ui): updates for button, density and colors #1939)
  • Button group
  • Card base — (previously Card)
  • Dialog
  • Input field — (major changes) (feat(ui): TextInput updates #1942)
  • Icon
  • Icon Adornment (feat(ui): TextInput updates #1942)
  • Identicon — (no changes)
  • List item — (major changes)
  • Menu item
  • Pill
  • Popover
  • Segmented control
  • Slider
  • Swap asset selector — (new component)
  • Swap Claim — (new component)
  • Swap Value Input
  • Swap routing
  • Navigation bar
  • Tab
  • Table cell — (previously Table)
  • Toast — (new component)
  • Toggle — (no changes)
  • Tooltip
  • Value View — (major changes)
  • Wallet balance
  • Transaction Summary — (new component)

Pages (ready for dev)

  • Portfolio
  • Shielding
  • Transfer
  • Swap
  • Stake
@VanishMax
Copy link
Contributor

PR #1939 checks these items: Color, Button

@TalDerei
Copy link
Contributor

PR #1941: Address View component

@grod220
Copy link
Collaborator

grod220 commented Dec 11, 2024

Let's put the PRs in line with the checklist item 🙏

@hdevalence
Copy link
Member

hdevalence commented Dec 13, 2024

Can we break down the action views into a list with sub-items? There are a fair number of them so would be useful to track separately.

EDIT: I filled them in from the list https://buf.build/penumbra-zone/penumbra/docs/main:penumbra.core.transaction.v1#penumbra.core.transaction.v1.ActionView and assigned them priorities relative to the other actions

@smmhrdmn
Copy link
Author

Can we break down the action views into a list with sub-items? There are a fair number of them so would be useful to track separately.

EDIT: I filled them in from the list https://buf.build/penumbra-zone/penumbra/docs/main:penumbra.core.transaction.v1#penumbra.core.transaction.v1.ActionView and assigned them priorities relative to the other actions

@hdevalence as we've discussed, not all of these are addressed in figma (although the missing views are noted in figma). we mentioned implementing the missing views in the same way they've been rendered in the past. is that still the plan? should we continue trying to fill these out?

@hdevalence
Copy link
Member

They need to be implemented as components, but the ones that don't have designs could be something as simple as

Action Name
(!) Unimplemented Action

The important thing is to have all the components there so that, e.g., the tx view can render the list of actions correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🗄️ Backlog
Development

No branches or pull requests

5 participants