-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIv2 Library Designs — Tracking List #1937
Comments
PR #1939 checks these items: Color, Button |
PR #1941: |
Let's put the PRs in line with the checklist item 🙏 |
Can we break down the action views into a list with sub-items? There are a fair number of them so would be useful to track separately. EDIT: I filled them in from the list https://buf.build/penumbra-zone/penumbra/docs/main:penumbra.core.transaction.v1#penumbra.core.transaction.v1.ActionView and assigned them priorities relative to the other actions |
@hdevalence as we've discussed, not all of these are addressed in figma (although the missing views are noted in figma). we mentioned implementing the missing views in the same way they've been rendered in the past. is that still the plan? should we continue trying to fill these out? |
They need to be implemented as components, but the ones that don't have designs could be something as simple as
The important thing is to have all the components there so that, e.g., the tx view can render the list of actions correctly |
Is your feature request related to a problem? Please describe.
New ui designs need to be implemented so minifront can be updated and others can utilize the library.
Describe the solution you'd like
Call the current state of the UIv2 Library done, and begin implementing changes. This tracking list can be used to mark off components that have been fully implemented into the ui library. As components are implemented or issues are created from here, please make note of them here.
Describe alternatives you've considered
n/a
Additional context
Primitives (ready for dev)
Semantics (ready for dev)
Components (ready for dev)
SpendView
(P1)OutputView
(P1)SwapView
(P1)SwapClaimView
(P1)DelegatorVoteView
(P3)ValidatorDefinition
(P3)IbcRelay
(P1)ProposalSubmit
(P3)ProposalWithdraw
(P3)ValidatorVote
(P3)ProposalDepositClaim
(P3)PositionOpen
(P1)PositionClose
(P1)PositionWithdraw
(P1)Delegate
(P2)Undelegate
(P2)CommunityPoolSpend
(P4)CommunityPoolOutput
(P4)CommunityPoolDeposit
(P4)ActionDutchAuctionScheduleView
(P2)ActionDutchAuctionEnd
(P2)ActionDutchAuctionWithdrawView
(P2)UndelegateClaim
(P2)Ics20Withdraw
(P1)Pages (ready for dev)
The text was updated successfully, but these errors were encountered: