Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject Swap approvals with foreign claim addresses #548

Closed
Tracked by #389
hdevalence opened this issue Feb 15, 2024 · 0 comments · Fixed by #821
Closed
Tracked by #389

Reject Swap approvals with foreign claim addresses #548

hdevalence opened this issue Feb 15, 2024 · 0 comments · Fixed by #821
Assignees
Labels
rpc Related to proto rpc services/methods

Comments

@hdevalence
Copy link
Member

The claim address is specified in the SwapPlan. It should always be an address the user controls.

The extension's approval code should check that any submitted SwapPlan has a claim address controlled by the user, and automatically reject it if not.

Adding this check means that we don't need to display the claim address to the user in the approval view.

@hdevalence hdevalence mentioned this issue Feb 15, 2024
16 tasks
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Feb 15, 2024
@grod220 grod220 added the rpc Related to proto rpc services/methods label Feb 22, 2024
@grod220 grod220 moved this from 🗄️ Backlog to 📝 Todo in Penumbra web Mar 21, 2024
@jessepinho jessepinho moved this from 📝 Todo to 🏗 In progress in Penumbra web Mar 22, 2024
@jessepinho jessepinho self-assigned this Mar 22, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Penumbra web Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc Related to proto rpc services/methods
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants