Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate unbonding token metadata on the fly for the approval dialog #856

Closed
jessepinho opened this issue Mar 28, 2024 · 0 comments · Fixed by #896
Closed

Generate unbonding token metadata on the fly for the approval dialog #856

jessepinho opened this issue Mar 28, 2024 · 0 comments · Fixed by #896
Assignees
Labels
rpc Related to proto rpc services/methods

Comments

@jessepinho
Copy link
Contributor

Image

Right now, the unbonding tokens in the transaction approval dialog are rendered as "unknown asset". This is because the token metadata for this unbonding token doesn't yet exist, since it's specific to the block that unbonding starts at.

To fix this, we'll need to generate token metadata for unbonding tokens on the fly, using logic similar to this.

@jessepinho jessepinho converted this from a draft issue Mar 28, 2024
@grod220 grod220 added rpc Related to proto rpc services/methods mainnet labels Apr 2, 2024
@grod220 grod220 moved this from 🗄️ Backlog to 📝 Todo in Penumbra web Apr 4, 2024
@jessepinho jessepinho moved this from 📝 Todo to 🏗 In progress in Penumbra web Apr 4, 2024
@jessepinho jessepinho self-assigned this Apr 4, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Penumbra web Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc Related to proto rpc services/methods
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants