Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension makes a lot of requests during sync #887

Closed
hdevalence opened this issue Apr 4, 2024 · 4 comments · Fixed by #1469
Closed

Extension makes a lot of requests during sync #887

hdevalence opened this issue Apr 4, 2024 · 4 comments · Fixed by #1469
Assignees
Labels
rpc Related to proto rpc services/methods

Comments

@hdevalence
Copy link
Member

While attempting to sync on a slow network, I opened the network inspector on the popup to see how it was making progress. I noticed two surprises:

  • There were dozens to hundreds of AssetMetadataById requests at the outset. Looking at them, they seemed mostly requesting info on delegation tokens. Could these be coalesced into a single request?
  • During sync, there were hundreds of AppParameters requests. I'm not sure why these are required during sync?
@hdevalence
Copy link
Member Author

On the second point, it looks like the culprit is in handleEpochTransition:

    const { sctParams } = await this.querier.app.appParams();

This should be using the local data rather than making a network request.

@hdevalence
Copy link
Member Author

@jessepinho
Copy link
Contributor

There were dozens to hundreds of AssetMetadataById requests at the outset. Looking at them, they seemed mostly requesting info on delegation tokens. Could these be coalesced into a single request?

Looks like this is blocked by penumbra-zone/penumbra#4162. Once that's done, this ticket will be ready to pull in.

During sync, there were hundreds of AppParameters requests. I'm not sure why these are required during sync?

@Valentine1898 just fixed this.

@hdevalence
Copy link
Member Author

@Valentine1898 Nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc Related to proto rpc services/methods
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants