Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding improvement: return the user to the grpc selection step if he skipped it #993

Closed
Valentine1898 opened this issue Apr 26, 2024 · 4 comments
Closed

Onboarding improvement: return the user to the grpc selection step if he skipped it #993

Valentine1898 opened this issue Apr 26, 2024 · 4 comments
Assignees
@Valentine1898
Labels
enhancement

Comments

@Valentine1898
Copy link
Contributor

Valentine1898 commented Apr 26, 2024 •
edited
Loading

If a user interrupts onboarding at the RPC selection stage and comes back after some time, instead of continuing onboarding he gets a broken extension for which grpcEndpoint is not set

UPD:
After #994 it no longer breaks extension, see comments below
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Apr 26, 2024
This was referenced Apr 26, 2024
Closed
Merged
@turbocrime
Copy link
Contributor

probably we need to add an "onboarding complete" key to storage

@grod220 grod220 moved this from 🗄️ Backlog to 📝 Todo in Penumbra web Apr 29, 2024
@grod220 grod220 added mainnet infra Low-level infrastructure updates bug Something isn't working and removed infra Low-level infrastructure updates labels Apr 29, 2024
@turbocrime
Copy link
Contributor

is this still an issue

@Valentine1898
Copy link
Contributor Author

is this still an issue

If you stop onboarding to select grpcEndpoint, it no longer results in a broken extension. This is fixed in #994 by setting the default grpcEndpoint.
But we can still improve the user experience, and instead of setting the default, return the user to the onboarding step with the grpcEndpoint selection

@Valentine1898 Valentine1898 changed the title if user interrupts onboarding during the RPC selection phase he will get a broken extension Onboarding improvement: return the user to the grpc selection step if he skipped it May 9, 2024
@Valentine1898 Valentine1898 added enhancement and removed bug Something isn't working mainnet labels May 9, 2024
@grod220 grod220 moved this from 📝 Todo to 🗄️ Backlog in Penumbra web May 9, 2024
@Valentine1898
Copy link
Contributor Author

prax-wallet/prax#66 solved it

@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra web Jul 2, 2024
@Valentine1898 Valentine1898 self-assigned this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Valentine1898 Valentine1898

Labels
enhancement
Projects
Penumbra web
Archived in project
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/993-if-user-interrupts-onboarding-during-the-rpc-selection-phase-he-will-get-a-broken-extension penumbra-zone/web
3 participants
@grod220 @Valentine1898 @turbocrime