Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The validation view does not return right headers #257

Closed
moumoutte opened this issue Sep 7, 2017 · 0 comments · Fixed by #258
Closed

The validation view does not return right headers #257

moumoutte opened this issue Sep 7, 2017 · 0 comments · Fixed by #258
Assignees
@moumoutte
Milestone
1.0.1

Comments

@moumoutte
Copy link
Contributor

The initial method in django rest framework , which actually return the final response is processing by finalize_response which actually apply the default headers. Consequences the actual view does not return a response json/application.

Moreover the exceptions.Http404 seems to no exist anymore, and have to be replace by exceptions.NotFound
@moumoutte moumoutte self-assigned this Sep 7, 2017
moumoutte added a commit that referenced this issue Sep 7, 2017
@moumoutte
refs #257, Fix the exception raised when formidable not found
e4f92e8
moumoutte added a commit that referenced this issue Sep 7, 2017
@moumoutte
refs #257, Add default dict to have right content-type
5197585
@moumoutte moumoutte mentioned this issue Sep 7, 2017
Merged
2 tasks
moumoutte added a commit that referenced this issue Sep 7, 2017
@moumoutte
refs #257, Add default dict to have right content-type
1955fe6
@brunobord brunobord added this to the 1.0.1 milestone Sep 8, 2017
moumoutte added a commit that referenced this issue Sep 8, 2017
@moumoutte
refs #257, Fix the exception raised when formidable not found
388eedb
moumoutte added a commit that referenced this issue Sep 8, 2017
@moumoutte
refs #257, Add default dict to have right content-type
8a3c17e
moumoutte added a commit that referenced this issue Sep 14, 2017
@moumoutte
refs #257, Fix the exception raised when formidable not found
6483aee
moumoutte added a commit that referenced this issue Sep 14, 2017
@moumoutte
refs #257, Add default dict to have right content-type
d156519
moumoutte added a commit that referenced this issue Oct 3, 2017
@moumoutte
refs #257, Add default dict to have right content-type
cfb5d1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moumoutte moumoutte

Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

Validate review returns the right content type peopledoc/django-formidable
2 participants
@brunobord @moumoutte