Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate dynamic form queryset #156

Closed
wants to merge 11 commits into from
Closed

Deduplicate dynamic form queryset #156

wants to merge 11 commits into from

Conversation

moumoutte
Copy link
Contributor

@moumoutte moumoutte commented Jan 15, 2017 •
edited
Loading

refs #155

/!\ need #154 to be merged, which actually introduce django-perf-rec into django-formidable

In master

TestDynamicForm.test_queryset_with_role:
- db: 'SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" = # ORDER BY "formidable_field"."order" ASC'
- db: 'SELECT ... FROM "formidable_access" WHERE ("formidable_access"."field_id" = # AND "formidable_access"."access_id" = #)'
- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
- db: 'SELECT ... FROM "formidable_access" WHERE ("formidable_access"."field_id" = # AND "formidable_access"."access_id" = #)'
- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
- db: 'SELECT ... FROM "formidable_access" WHERE ("formidable_access"."field_id" = # AND "formidable_access"."access_id" = #)'
- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
- db: 'SELECT ... FROM "formidable_item" WHERE "formidable_item"."field_id" = #'
- db: 'SELECT ... FROM "formidable_access" WHERE ("formidable_access"."field_id" = # AND "formidable_access"."access_id" = #)'
- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
- db: 'SELECT ... FROM "formidable_item" WHERE "formidable_item"."field_id" = #'
- db: 'SELECT ... FROM "formidable_preset" WHERE "formidable_preset"."form_id" = #'
TestDynamicForm.test_queryset_without_role:
- db: 'SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" = # ORDER BY "formidable_field"."order" ASC'
- db: 'SELECT ... FROM "formidable_access" WHERE ("formidable_access"."field_id" = # AND "formidable_access"."access_id" = #)'
- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
- db: 'SELECT ... FROM "formidable_access" WHERE ("formidable_access"."field_id" = # AND "formidable_access"."access_id" = #)'
- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
- db: 'SELECT ... FROM "formidable_access" WHERE ("formidable_access"."field_id" = # AND "formidable_access"."access_id" = #)'
- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
- db: 'SELECT ... FROM "formidable_item" WHERE "formidable_item"."field_id" = #'
- db: 'SELECT ... FROM "formidable_access" WHERE ("formidable_access"."field_id" = # AND "formidable_access"."access_id" = #)'
- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
- db: 'SELECT ... FROM "formidable_item" WHERE "formidable_item"."field_id" = #'
- db: 'SELECT ... FROM "formidable_preset" WHERE "formidable_preset"."form_id" = #'

in current branch

TestDynamicForm.test_queryset_with_role:
- db: 'SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" = # ORDER BY "formidable_field"."order" ASC'
- db: SELECT ... FROM "formidable_item" WHERE "formidable_item"."field_id" IN (...) ORDER BY "formidable_item"."order" ASC
- db: 'SELECT ... FROM "formidable_access" WHERE ("formidable_access"."access_id" = # AND "formidable_access"."field_id" IN (...))'
- db: SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" IN (...)
- db: SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" IN (...)
- db: 'SELECT ... FROM "formidable_preset" WHERE "formidable_preset"."form_id" = #'
TestDynamicForm.test_queryset_without_role:
- db: 'SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" = # ORDER BY "formidable_field"."order" ASC'
- db: SELECT ... FROM "formidable_item" WHERE "formidable_item"."field_id" IN (...) ORDER BY "formidable_item"."order" ASC
- db: 'SELECT ... FROM "formidable_access" WHERE ("formidable_access"."access_id" = # AND "formidable_access"."field_id" IN (...))'
- db: SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" IN (...)
- db: SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" IN (...)
- db: 'SELECT ... FROM "formidable_preset" WHERE "formidable_preset"."form_id" = #'

@moumoutte
refs #54, add django perf rec into django-formidable
8016754 
until the sqllite driver is not compatible with django_perf_rec
adamchainz/django-perf-rec#50, we have to provide
an overrided sqllite driver backend to be able to record verbosely each
recorded SQL line.
@moumoutte
refs #54, add sql test recorder on retrieve context form from API
d0a3437
@moumoutte
refs #54, disambiguate the URL's in order to fetch context form
174ff03
@moumoutte
refs #54, order items in the fields serializer
0ddc5a6
@moumoutte
refs #54, order fields in form serializer
870ef95
@moumoutte
refs #54, add sql tests on serializer only
b152027
@moumoutte
refs #54, use the prefetch to check access directly
22f82f6
@moumoutte
refs #155, added test to count queries
fbe1ff5
@moumoutte
refs #155, add Prefetch related object on fields queryset
6c66536
@moumoutte
refs #155, actually use the accesses list already loaded by the main …
d7303bf 
…method
@moumoutte
refs #155, add the SQL perfs record file
68052d8
@moumoutte moumoutte force-pushed the deduplicate_dynamic_form_queryset branch from 587d549 to 68052d8 Compare January 15, 2017 16:31
@moumoutte moumoutte closed this Jan 16, 2017
@brunobord brunobord reopened this Jan 16, 2017
@brunobord brunobord mentioned this pull request Jan 16, 2017
Merged
2 tasks
brunobord added a commit that referenced this pull request Jan 16, 2017
@brunobord
Added test to count queries on dynamic form queryset + improve perfor…
40da5d8 
…mances

closes #155, #156
brunobord added a commit that referenced this pull request Jan 16, 2017
@brunobord
Added test to count queries on dynamic form queryset + improve perfor…
124720c 
…mances

closes #155, #156
@brunobord
Copy link
Contributor

superseded by #162

@brunobord brunobord closed this Jan 16, 2017
brunobord added a commit that referenced this pull request Jan 17, 2017
@brunobord
v0.6.0
df78cfb 
Changelog

* Added a make target to install the demo site (#152).
* Added django-perf-rec module for tests and improved SQL queries in `ContextFormDetailView` (#54, #154, #160).
* Added test to count queries on dynamic form queryset + improve performances (#155, #156, #162).
* Added test to count queries on retrieve builder view + improve performances by removing duplicate queries (#157, #158, #163).
@brunobord brunobord mentioned this pull request Jan 17, 2017
Merged
@moumoutte moumoutte deleted the deduplicate_dynamic_form_queryset branch February 20, 2017 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moumoutte @brunobord