Deduplicate queries retrieve builder view #163
Conversation
brunobord
changed the title
| UpdateFormTestCase.test_queryset_on_get: | ||
| - db: 'SELECT ... FROM "formidable_formidable" WHERE "formidable_formidable"."id" = #' | ||
| - db: SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" IN (#) ORDER BY "formidable_field"."order" ASC | ||
| - db: 'SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" = # ORDER BY "formidable_field"."order" ASC' |
There was a problem hiding this comment.
Hum seems to have an extra queries here ?
There was a problem hiding this comment.
Actually the line above.
There was a problem hiding this comment.
mmmmm... I don't know, I didn't try to change anything on your code, only the .yml files ; it's possible that your previous perf PRs had a side-effect on the queries generated in the next perf PRs.
Maybe you'd want to add commits to this branch and eventually tackle one last performance issue? or we may merge "as is", and we open an issue to resolve this one? your choice, this PR is the last one to integrate into django-formidable, it won't have any bad side-effect, IMHO
There was a problem hiding this comment.
I think I miss this one , do you mind if I add a commit ?
brunobord
force-pushed
the
157_deduplicate_queries_retrieve_builder_view
branch
from
f6f5a3e
to
dbb8e64
Compare
Changelog * Added a make target to install the demo site (#152). * Added django-perf-rec module for tests and improved SQL queries in `ContextFormDetailView` (#54, #154, #160). * Added test to count queries on dynamic form queryset + improve performances (#155, #156, #162). * Added test to count queries on retrieve builder view + improve performances by removing duplicate queries (#157, #158, #163).
refs #157