Metadata 42 #45
Merged
Metadata 42 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewjoachim
force-pushed
the
metadata-42
branch
from
e7bc22e
to
fe32804
Compare
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 56.56% 57.14% +0.57%
==========================================
Files 13 14 +1
Lines 594 602 +8
Branches 81 81
==========================================
+ Hits 336 344 +8
Misses 251 251
Partials 7 7
Continue to review full report at Codecov.
|
|
tests/unit/test_init.py still uses |
ewjoachim
force-pushed
the
metadata-42
branch
from
fe32804
to
f7d5c10
Compare
|
@mgu rewrote unit test. We could also have an integration test. (but meh) |
|
@mgu ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
Successful PR Checklist: