Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a test workflow #100

Merged
merged 8 commits into from
Mar 11, 2019
Merged

Create a test workflow #100

merged 8 commits into from
Mar 11, 2019

Conversation

OrkoHunter
Copy link
Collaborator

@OrkoHunter OrkoHunter commented Dec 28, 2018

  • A new PR should create a new heroku app with a unique endpoint
  • The new app with the proposed code should be tested against a repository
  • The new app should be destroyed by the PR being merged.

Related - #46

@OrkoHunter OrkoHunter temporarily deployed to pep8speaks-pr-100 December 28, 2018 16:35 Inactive
@OrkoHunter
Copy link
Collaborator Author

Created a test app where the payload URL can be updated for testing each PR. The test app has been installed on the https://github.com/OrkoHunter/test-pep8speaks repository.

@OrkoHunter
Copy link
Collaborator Author

Using a Probot app called auto-comment, to comment the details of testing when a new PR is created.

Check out Probot apps! They are awesome - https://probot.github.io/apps/

@OrkoHunter OrkoHunter temporarily deployed to pep8speaks-pr-100 December 28, 2018 17:22 Inactive
@pep8speaks
Copy link
Contributor

pep8speaks commented Mar 11, 2019

Hello @OrkoHunter! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-03-11 21:05:37 UTC

@OrkoHunter OrkoHunter closed this Mar 11, 2019
@OrkoHunter OrkoHunter reopened this Mar 11, 2019
@OrkoHunter OrkoHunter temporarily deployed to pep8speaks-pr-100 March 11, 2019 17:40 Inactive
@OrkoHunter OrkoHunter temporarily deployed to pep8speaks-pr-100 March 11, 2019 20:42 Inactive
@OrkoHunter OrkoHunter temporarily deployed to pep8speaks-pr-100 March 11, 2019 20:50 Inactive
@OrkoHunter OrkoHunter temporarily deployed to pep8speaks-pr-100 March 11, 2019 21:03 Inactive
@OrkoHunter OrkoHunter changed the title WIP: Create a test workflow Create a test workflow Mar 11, 2019
@OrkoHunter OrkoHunter merged commit c580311 into master Mar 11, 2019
@OrkoHunter
Copy link
Collaborator Author

Finally! Our CI will test the core features on incoming Pull Requests.

@OrkoHunter OrkoHunter deleted the add_tests branch March 11, 2019 21:08
@OrkoHunter OrkoHunter mentioned this pull request Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants