Deprecare Flask-Session to fix master build #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency flask-session is broken because of a change pallets-eco/flask-session#114. Unfortunately, months have passed but no action has been taken to merge the fix. PEP8Speaks does not really need Flask-Session and hence, it is better to remove it.
|
💖 Thank you so much for creating the pull request! 💖 Have a look at the test workflow. The branch of this pull request is going to be deployed on Heroku with payload URL https://pep8speaks-pr-xxx.herokuapp.com . The repository https://github.com/OrkoHunter/test-pep8speaks is configured to test review deployments like this. @OrkoHunter Create a review app for this PR on Heroku and update the |
OrkoHunter
force-pushed
the
deprecate-flask-session
branch
from
af64709 to
cf1549a
Compare
It does not recognize Python-3.7
|
Not sure why GitHub checks is hung, but the build succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency flask-session is now broken because of a change in
werkzeuglibrary. pallets-eco/flask-session#114.Unfortunately, months have passed but no action has been taken to merge the fix.
PEP8Speaks does not really need Flask-Session and hence, it is better to remove it.
Closes #164 #165