Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newly discovered typos #691

Merged
merged 1 commit into from
Nov 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bin/pt-online-schema-change
Original file line number Diff line number Diff line change
Expand Up @@ -11175,7 +11175,7 @@ sub determine_alter_fk_method {
return ''; # $alter_fk_method can't be undef
}

# The rebuild_constraints method is the default becuase it's safer
# The rebuild_constraints method is the default because it's safer
# and doesn't cause the orig table to go missing for a moment.
my $method = 'rebuild_constraints';

Expand Down Expand Up @@ -11630,7 +11630,7 @@ sub random_suffix {
# duplicate_trigger: If set, it will create the trigger on the new table
# with a random string as a trigger name suffix.
# It will also not drop the original trigger.
# This is usefull when creating a temporary trigger for testing
# This is useful when creating a temporary trigger for testing
# purposes or if --no-swap-tables AND --no-drop-new-table was
# specified along with --preserve-triggers. In this case,
# since the original table and triggers are not going to be
Expand Down
4 changes: 2 additions & 2 deletions bin/pt-table-checksum
Original file line number Diff line number Diff line change
Expand Up @@ -10955,11 +10955,11 @@ sub main {
# the user does --chunk-size-limit=0 to disable the 1st, documented
# purpose because, apparently, they're using non-unique indexes and
# they don't care about potentially large chunks. But disabling the
# 1st purpose adversely affects the 2nd purpose becuase 0 * the chunk size
# 1st purpose adversely affects the 2nd purpose because 0 * the chunk size
# will always be zero, so tables will only be single-chunked if EXPLAIN
# says there are 0 rows, but sometimes EXPLAIN says there is 1 row
# even when the table is empty. This wouldn't matter except that nibbling
# an empty table doesn't currently work becuase there are no boundaries,
# an empty table doesn't currently work because there are no boundaries,
# so no checksum is written for the empty table. To fix this and
# preserve the two purposes of this option, usages of the 2nd purpose
# do || 1 so the limit is never 0 and empty tables are single-chunked.
Expand Down