Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some optimisations #7

Merged
merged 7 commits into from
May 6, 2024
Merged

Added some optimisations #7

merged 7 commits into from
May 6, 2024

Conversation

peremato
Copy link
Member

@peremato peremato commented May 6, 2024

  • Added the function RootIO.create_getter(reader::Reader, bname::String; selection=nothing) to create a getter function for a specific branch. This is needed before the event loop is started. The optional argument allows to select the leaves to be read.
  • The overall performance is highly improved (factor 3 with respect previous version)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 14.75410% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 77.14%. Comparing base (80eeb2e) to head (5dbbd91).
Report is 1 commits behind head on main.

Files Patch % Lines
src/RootIO.jl 16.07% 47 Missing ⚠️
src/Components.jl 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   83.88%   77.14%   -6.74%     
==========================================
  Files           7        7              
  Lines         422      477      +55     
==========================================
+ Hits          354      368      +14     
- Misses         68      109      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peremato peremato merged commit 895d9dc into main May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants