Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to import pSConfig format #76

Closed
arlake228 opened this issue Dec 6, 2018 · 2 comments
Closed

Ability to import pSConfig format #76

arlake228 opened this issue Dec 6, 2018 · 2 comments
Assignees
@apertome
Labels
enhancement

Comments

@arlake228
Copy link
Collaborator

arlake228 commented Dec 6, 2018 •
edited
Loading

From a user:

When I try to import your mesh JSON file at http://icnmgmt0.internet2.edu/psconfig/osg_stashcache_templates.json I get this exception:

1|pwaadmin | Thu Dec 06 2018 14:54:42 GMT+0000 (UTC) - error: Thu, 06 Dec 2018 14:54:42 GMT uncaughtException: Cannot read property 'forEach' of undefined
1|pwaadmin | Thu Dec 06 2018 14:54:42 GMT+0000 (UTC) - error: TypeError: Cannot read property 'forEach' of undefined
1|pwaadmin | at Object.exports._process_imported_config (/app/api/admin/controllers/importer.js:206:29)
1|pwaadmin | at Request._callback (/app/api/admin/controllers/importer.js:168:17)
1|pwaadmin | at Request.self.callback (/app/node_modules/request/request.js:185:22)
1|pwaadmin | at emitTwo (events.js:106:13)
1|pwaadmin | at Request.emit (events.js:191:7)
1|pwaadmin | at Request. (/app/node_modules/request/request.js:1161:10)
1|pwaadmin | at emitOne (events.js:96:13)
1|pwaadmin | at Request.emit (events.js:188:7)
1|pwaadmin | at IncomingMessage. (/app/node_modules/request/request.js:1083:12)
1|pwaadmin | at IncomingMessage.g (events.js:292:16)
1|pwaadmin | at emitNone (events.js:91:20)
1|pwaadmin | at IncomingMessage.emit (events.js:185:7)
1|pwaadmin | at endReadableNT (_stream_readable.js:974:12)
1|pwaadmin | at _combinedTickCallback (internal/process/next_tick.js:80:11)
1|pwaadmin | at process._tickDomainCallback (internal/process/next_tick.js:128:9)

It is likely that there are bugs in PWA and I don't believe the mesh config imported was checked or modified much from the original MCA implementation.
@apertome apertome self-assigned this Jan 9, 2019
@apertome
Copy link
Contributor

apertome commented Jan 16, 2019 •
edited
Loading

The issue here is that ironically, PWA does not know how to import pSConfig templates, only MeshConfig format.

@apertome apertome changed the title MeshConfig import issue Ability to import pSConfig format Jan 16, 2019
apertome added a commit that referenced this issue Jan 28, 2019
@apertome
Fix a race condition in importer unit test #76
c9ce58d
apertome added a commit that referenced this issue Jan 29, 2019
@apertome
Add importer unit tests for detecting psconfig/meshconfig format #76
cddea65
apertome added a commit that referenced this issue Feb 5, 2019
@apertome
Retrieving MAs from psconfig is working #76
c7e565a
apertome added a commit that referenced this issue Feb 7, 2019
@apertome
Retrieving MAs from psconfig is working #76
e7decf7
@apertome apertome added this to the sprint-20190304 milestone Feb 20, 2019
apertome added a commit that referenced this issue Mar 4, 2019
@apertome
Some improvements to importer #76
8bbf6c1
@arlake228 arlake228 removed this from the sprint-20190318 milestone Apr 24, 2019
apertome added a commit that referenced this issue Aug 14, 2019
@apertome
Working on psconfig import #76
7d56027
apertome added a commit that referenced this issue Aug 14, 2019
@apertome
Working on psconfig import #76
968e6d6
apertome added a commit that referenced this issue Aug 27, 2019
@apertome
Merge in 4.3.0 to update this branch #76
38ee306
apertome added a commit that referenced this issue Sep 5, 2019
@apertome
Add archivers to psconfig import #76
1b02309
apertome added a commit that referenced this issue Sep 6, 2019
@apertome
Testspecs mostly set #76
735a066
apertome added a commit that referenced this issue Sep 12, 2019
@apertome
Testspecs being added to object #76
b0a884b
apertome added a commit that referenced this issue Sep 12, 2019
@apertome
Add hostgroups #76
94a72ae
apertome added a commit that referenced this issue Sep 16, 2019
@apertome
Add testspecs #76
823a507
apertome added a commit that referenced this issue Sep 16, 2019
@apertome
Add schedule/duration #76
aec8cf4
apertome added a commit that referenced this issue Sep 17, 2019
@apertome
Import basically working; not selecting testspec just yet #76
a2be4f6
apertome added a commit that referenced this issue Sep 17, 2019
@apertome
Import now working; fix omit flag #76
7e2c404
apertome added a commit that referenced this issue Sep 17, 2019
@apertome
Clean up psconfig import code #76
ded0ca9
apertome added a commit that referenced this issue Sep 20, 2019
@apertome
Fix host import for meshconfig format #76
614a237
apertome added a commit that referenced this issue Sep 20, 2019
@apertome
Clean up importer #76
1ee7f70
apertome added a commit that referenced this issue Sep 20, 2019
@apertome
Fix adding hosts to hostgroup on import; add desc back in #76
dd8573c
apertome added a commit that referenced this issue Sep 20, 2019
@apertome
Prepare for 4.2.1 release #76
2f841bf
apertome added a commit that referenced this issue Sep 20, 2019
@apertome
Prepare for 4.2.1 release #76
cddafcc
@apertome apertome mentioned this issue Sep 20, 2019
Open
@apertome
Copy link
Contributor

We have the ability to import psconfig format now, but disjoint meshes are not supported. There is a separate ticket for tracking that functionality, #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apertome apertome

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arlake228 @apertome