Remove WebsocketRPCEndpoint.on_connect #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is never called and unused, likely left out from the cleanup after setting up RpcChannel.register_connect_handler (see for example a471d54).
orweis
approved these changes
Jul 29, 2024
|
@danielbass37 please offer @5p4k some thank you swag. |
|
Hey @5p4k! Sorry for the delay - I'd love to offer you some swag as a thank-you for your contribution. Are you in our Slack community by any chance? I would need you to provide an address for me to which I could send everything :) |
|
That's very kind of you @danielbass37 ! I'll ping you on Slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is never called and unused, likely left out from the cleanup after setting up
RpcChannel.register_connect_handler(see for example a471d54).I thought that removal would be the best solution. Restoring the functionality would require to call it instead of the handlers passed at construction, which would be an odd choice given that there are no other customization methods (like e.g.
on_disconnect) left in the class. Besides, any user of the class that is relying on it is currently not getting their method called.This closes #39 .