Merge pull request #1 from personnummer/format-coordination-number

Format coordination numbers correct
personnummer · Apr 20, 2020 · 45cfebe · 45cfebe
2 parents baaba0a + fd95168
commit 45cfebe
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 11 deletions.
diff --git a/lib/Personnummer.pm b/lib/Personnummer.pm
@@ -7,7 +7,7 @@ use feature qw( say );
 use Carp;
 use DateTime;
 
-our $VERSION = '0.01';
+our $VERSION = '3.00';
 
 sub new {
     my ( $class, $pnr ) = @_;
@@ -33,14 +33,10 @@ sub format {
     croak "cannot format invalid social security numbers" if not $self->valid();
 
     my $year = $long_format ? $self->{date}->year : $self->{date}->year % 100;
+    my $day = $self->{is_coordination_number} ? $self->{date}->day + 60 : $self->{date}->day;
 
-    return sprintf(
-        "%s%02d%02d-%03d%d",
-        $year,
-        $self->{date}->month,
-        $self->{date}->day,
-        $self->{serial}, $self->{control}
-    );
+    return
+      sprintf( "%s%02d%02d-%03d%d", $year, $self->{date}->month, $day, $self->{serial}, $self->{control} );
 }
 
 sub get_age {
@@ -105,7 +101,9 @@ sub _luhn {
         $even ^= 1;
     }
 
-    return 10 - ( $sum % 10 );
+    my $checksum = 10 - ( $sum % 10 );
+
+    return $checksum == 10 ? 0 : $checksum;
 }
 
 sub _parse {

diff --git a/t/00-basic.t b/t/00-basic.t
@@ -42,6 +42,11 @@ subtest 'Formatting' => sub {
             short => "900101-0017",
             long  => "19900101-0017"
         },
+        {
+            input => "900161-0017",
+            short => "900161-0017",
+            long  => "19900161-0017"
+        },
     );
 
     foreach my $tc ( @cases ) {

diff --git a/t/10-validate.t b/t/10-validate.t
@@ -8,8 +8,8 @@ use Personnummer;
 
 subtest 'Valid social security numbers' => sub {
     my @cases = (
-        "20160229-1237", "6403273813",  "19900101-0017", "196408233234",
-        "000101-0107",   "510818-9167", "19130401+2931", "0001010107"
+        "20160229-1237", "6403273813", "19900101-0017", "196408233234", "000101-0107", "510818-9167",
+        "19130401+2931", "0001010107", "19090903-6600",
     );
 
     foreach my $tc ( @cases ) {