Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review request #259

Open
iryston opened this issue Aug 4, 2016 · 3 comments
Open

Review request #259

iryston opened this issue Aug 4, 2016 · 3 comments

Comments

@iryston
Copy link
Contributor

iryston commented Aug 4, 2016

Hi, @perusio

Can you take a look at my fork
I've made total synchronisation between branches, and publish them as D6-SYNC, D7-SYNC and master-SYNC.
If you don't have objection for this work, I'll do pull request.

One serious change which can break working sites is 'Rename poll, status and ping'

All other changes are most cosmetic and typo fixes.

Regards,
Igor

@kkomelin
Copy link
Contributor

kkomelin commented Oct 24, 2016

Hi @iryston ,

I think you've done a great job. I would recommend you splitting your changes into separate independent features and create corresponding pull requests (PRs) to make code review easier.

@iryston
Copy link
Contributor Author

iryston commented Oct 24, 2016

@kkomelin Thanks for recommendations. I'll recreate it in separate pull requests.

@andypost
Copy link

andypost commented Nov 9, 2017

Please recreate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants