Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install does not create nginx_dissite #12

Open
arturmartins opened this issue Aug 25, 2015 · 4 comments
Open

make install does not create nginx_dissite #12

arturmartins opened this issue Aug 25, 2015 · 4 comments

Comments

@arturmartins
Copy link

After running make install, no nginx_dissite was created.

workaround:

cd /usr/local/bin
ln -s nginx_ensite nginx_dissite
@perusio
Copy link
Owner

perusio commented Aug 28, 2015

@arturmartins can you try the above?

Obrigado

@helderco
Copy link

# make install
for dir in `find bin share -type d`; do mkdir -p /usr/local/$dir; done
for file in `find bin share -type f`; do cp $file /usr/local/$file; done
mkdir -p /usr/local/share/doc/nginx_ensite-1.0.0
cd /usr/local/bin
ln -s nginx_ensite nginx_dissite
ln: failed to create symbolic link ‘nginx_dissite’: File exists
make: *** [install] Error 1
# ls -lh /usr/local/bin/nginx*
-rwxr-xr-x 1 root root 6.5K Sep 11 13:30 /usr/local/bin/nginx_ensite

??

Works if done manually though... but this is making my Salt states fail.

@helderco
Copy link

Looks like ln -s nginx_ensite nginx_dissite in make install is not doing the cd /usr/local/bin. In other words, he's creating the link in the current dir.

I'd also want to be able to run make install repeatedly without failing. I recommend changing those three lines to:

-       cd $(DESTDIR)$(PREFIX)/bin
-       ln -s nginx_ensite nginx_dissite
-       cd $(CURR_DIR)
+       (cd $(DESTDIR)$(PREFIX)/bin && ln -sf nginx_ensite nginx_dissite)

@perusio
Copy link
Owner

perusio commented Sep 12, 2015

@helderco see this.

I used a test for the symlink.

Obrigado

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants