Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing rules between grammars? #197

Closed
waywardmonkeys opened this issue Feb 19, 2018 · 3 comments · Fixed by #758
Closed

Sharing rules between grammars? #197

waywardmonkeys opened this issue Feb 19, 2018 · 3 comments · Fixed by #758
Labels
good-first-issue help-wanted mentored needs-rfc
Milestone
v3.0

Comments

@waywardmonkeys
Copy link
Contributor

I have a few grammars for related formats / languages that share some common rules. Is there a way to readily share rules between separate grammar files?

It wouldn't make sense to just have a single big grammar file.

In nom, I would be able to define new combinators that I'd use for things like basic types and such.
@dragostis
Copy link
Contributor

Good point. There should be an import command in .pest files. This could be added in 1.1. Let me know if you want to tackle it.

@dragostis dragostis added this to the v1.1 milestone Feb 19, 2018
@waywardmonkeys
Copy link
Contributor Author

Could you provide a couple of getting started pointers and I will see if I can tackle it?

@dragostis
Copy link
Contributor

Of course. The necessary grammar should be added to meta. Probably something like use generic.pest would do well.

Then this should be somehow integrated into the parser and validator in the meta crate. I'm not completely sure what the best approach would be in this case. My current hunch is to do the actual importing in parser::convert_rules, where one could call parse and validate recursively, but this might not work and a change in architecture may be needed.

This was referenced Jun 1, 2018
Closed
Merged
@dragostis dragostis removed this from the v2.0 milestone Aug 12, 2018
@CAD97 CAD97 mentioned this issue Aug 24, 2018
Open
@CAD97 CAD97 mentioned this issue Oct 5, 2018
Open
@dragostis dragostis mentioned this issue Nov 6, 2018
Open
@DrSensor DrSensor mentioned this issue Jul 13, 2019
Open
@Abdillah Abdillah mentioned this issue Aug 14, 2021
Closed
@tomtau tomtau mentioned this issue Jul 23, 2022
Closed
@tomtau tomtau added this to the v3.0 milestone Jul 23, 2022
huacnlee added a commit to huacnlee/pest that referenced this issue Jan 4, 2023
@huacnlee
Add to support multiple grammars for derive generator.
4f3b531 
Resolve pest-parser#197

Example:

```rust
#[derive(Parser)]
#[grammar = "_base.pest"]
#[grammar = "json.pest"]
pub struct JSONParser;
``
huacnlee added a commit to huacnlee/pest that referenced this issue Jan 4, 2023
@huacnlee
Add to support multiple grammars for derive generator.
157f159 
Resolve pest-parser#197

Example:

```rust
#[derive(Parser)]
#[grammar = "_base.pest"]
#[grammar = "json.pest"]
pub struct JSONParser;
```

For supports sharing rules between grammars.
@huacnlee huacnlee mentioned this issue Jan 4, 2023
Merged
huacnlee added a commit to huacnlee/pest that referenced this issue Jan 4, 2023
@huacnlee
Add to support load multiple grammars for derive generator.
2949085 
Resolve pest-parser#197

Example:

```rust
#[derive(Parser)]
#[grammar = "_base.pest"]
#[grammar = "json.pest"]
pub struct JSONParser;
```

For supports sharing rules between grammars.
@huacnlee huacnlee mentioned this issue Jan 4, 2023
Closed
huacnlee added a commit to huacnlee/pest that referenced this issue Jan 4, 2023
@huacnlee
Add to support load multiple grammars for derive generator.
c825a36 
Resolve pest-parser#197

Example:

```rust
#[derive(Parser)]
#[grammar = "base.pest"]
#[grammar = "json.pest"]
pub struct JSONParser;
```

For supports sharing rules between grammars.
tomtau pushed a commit that referenced this issue Jan 5, 2023
@huacnlee
Add to support load multiple grammars for derive generator. (#758)
2f60362 
Resolve #197

Example:

```rust
#[derive(Parser)]
#[grammar = "base.pest"]
#[grammar = "json.pest"]
pub struct JSONParser;
```

For supports sharing rules between grammars.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue help-wanted mentored needs-rfc
Projects
None yet
Milestone
v3.0
3 participants
@waywardmonkeys @tomtau @dragostis