Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate files provided using Run.Path and -Path? #2530

Closed
fflaten opened this issue Jul 4, 2024 · 2 comments · Fixed by #2535
Closed

Deduplicate files provided using Run.Path and -Path? #2530

fflaten opened this issue Jul 4, 2024 · 2 comments · Fixed by #2535
Milestone

Comments

@fflaten
Copy link
Collaborator

fflaten commented Jul 4, 2024

Using "/tests", "/tests/.github" should be enough. You only need to specify the hidden folder, the rest will be found using recursion unless you want to include only a subset of folders under tests.

I tried this initially but the .github tests ran twice on windows which is also not ideal.

Originally posted by @tbutler-qontigo in #2515 (comment)

Should Pester deduplicate file paths provided using -Path / Run.Path? I don't see a reason why you'd want to run the same file multiple times without parameters.

Calling a file multiple times with different parameters (-Data) requires use of -Container / Run.Container which is unaffected by the suggested change to -Path.

@nohwnd
Copy link
Member

nohwnd commented Jul 5, 2024

Yes please, I thought we are already doing that.

@nohwnd nohwnd added this to the 5.x milestone Jul 5, 2024
@nohwnd
Copy link
Member

nohwnd commented Jul 5, 2024

Please implement in 6.0.0 and backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants