Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low contrast ratio #221

Open
4 of 5 tasks
fflaten opened this issue Aug 2, 2022 · 1 comment
Open
4 of 5 tasks

Low contrast ratio #221

fflaten opened this issue Aug 2, 2022 · 1 comment
Labels
theming Issues related to css/theming

Comments

@fflaten
Copy link
Collaborator

fflaten commented Aug 2, 2022 •
edited
Loading

Certain colors should be changed to have a better contrast ratio (foreground vs background) for improved readability and accessibility. Some of these are shown by Lighthose in Chromium.

  • Dark mode: Active link
    image
  • Both: Active section link
    image
  • Light mode: The pink and especially the turquoise color against the grey background used in the prism-theme (code blocks)
  • Light mode: The active page in the breadcrumbs and menu. Changing the background (--ifm-hover-overlay css-variable) slighty from 5% -> 4% alpha is an option.
  • Light mode: Placeholder-text in DocSearch. Could possibly ignore this.
@fflaten fflaten mentioned this issue Aug 10, 2022
Merged
@fflaten
Copy link
Collaborator Author

fflaten commented Aug 10, 2022

Related PR fixes everything above except prism-theme.

@fflaten fflaten added the theming Issues related to css/theming label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theming Issues related to css/theming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fflaten