Add authentication service along with user module #18
Conversation
codeAesthetic
commented
Jun 10, 2021
codeAesthetic
commented
- Add User module.
- Add Auth Service.
- Add .env example.
- Add env variables in CD.
1. Add User module. 2. Add .env example. 3. Add env variables in CD.
|
🚀 Netlify deployed juntos-frontend as draft https://60c206b88b805e29366ccf55--juntos-frontend.netlify.app |
|
🚀 Netlify deployed juntos-frontend as draft https://60c20f494c4554483d5c8130--juntos-frontend.netlify.app |
|
🚀 Netlify deployed juntos-frontend as draft https://60c2fe7dce399cd8fba58214--juntos-frontend.netlify.app |
1. Firebase mock written firebase user. 2. Add check if User exiting in auth methods.
|
🚀 Netlify deployed juntos-frontend as draft https://60c3259698bc8cde8dffbf69--juntos-frontend.netlify.app |
|
🚀 Netlify deployed juntos-frontend as draft https://60c337a947d22c00aad2eec8--juntos-frontend.netlify.app |
codeAesthetic
force-pushed
the
feature/auth-service
branch
from
4fd33c6
to
d790dbe
Compare
|
🚀 Netlify deployed juntos-frontend as draft https://60c35e3be496c331e1a1f602--juntos-frontend.netlify.app |
|
🚀 Netlify deployed juntos-frontend as draft https://60c35e895280723378c9ce88--juntos-frontend.netlify.app |
| signInWithEmailAndPassword: () => | ||
| Promise.resolve({ user: firebaseUser }), |
There was a problem hiding this comment.
We also need to mock these functions as per: https://jestjs.io/docs/mock-functions#using-a-mock-function
So that we can check if the same was called in the respective wrapper with a check like:
// The first argument of the first call to the function was 0
expect(signInWithEmialAndPassword.mock.calls[0][0]).toBe(0);There was a problem hiding this comment.
function that lies inside another function can't be mocked as you mentioned.
more details at following:-
There was a problem hiding this comment.
These two examples are different from our case. Can you try something like:
const mockSignInWithEmailAndPassword = jest.fn(({email, password}) => Promise.resolve({ user: firebaseUser }));
jest.mock("firebase", () => ({
...
return {
auth: () => ({
signInWithEmailAndPassword,
...
})
}
});
....
expect(mockSignInWithEmailAndPassword.mock.calls[0][0]).toBe("user@gmail.com");There was a problem hiding this comment.
mockSignInWithEmailAndPassword is simple mock function it can't test AuthService.ts file.
There was a problem hiding this comment.
Can you put this on a codesandbox with the above approach or share some references
There was a problem hiding this comment.
example you have given doesn't work so don't see the point of putting this in sandbox
There was a problem hiding this comment.
The codesandbox would allow me to explain the mocking. Can you create one and post the link here
There was a problem hiding this comment.
There was a problem hiding this comment.
Jest is not fully supported in codesandbox: codesandbox/codesandbox-client#513
|
🚀 Netlify deployed juntos-frontend as draft https://60c4cd6e9d8db318f832401a--juntos-frontend.netlify.app |
| signInWithEmailAndPassword: () => | ||
| Promise.resolve({ user: firebaseUser }), |
There was a problem hiding this comment.
These two examples are different from our case. Can you try something like:
const mockSignInWithEmailAndPassword = jest.fn(({email, password}) => Promise.resolve({ user: firebaseUser }));
jest.mock("firebase", () => ({
...
return {
auth: () => ({
signInWithEmailAndPassword,
...
})
}
});
....
expect(mockSignInWithEmailAndPassword.mock.calls[0][0]).toBe("user@gmail.com");
|
🚀 Netlify deployed juntos-frontend as draft https://60c5c51776cd88335a64c6f0--juntos-frontend.netlify.app |
