Catch up #1
Merged
Catch up #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #89 - clarify font licensing
`COMMENT` twice in pattern
The German Umlaute (ÄÖÜäöüß) are following directly to the standard characters (32-127) in the font files. Many fonts have them defined. But with the current logic they are ignored and not loaded.
Added fonts from a node js package specifically https://github.com/patorjk/figlet.js. The headers in these have been cross referenced with the ones currently available with pyfiglet.__version__ '0.8.post1'. The names of the fonts have been changed to all lower case and spaces have been replaced by _ to conform to the rest of the fonts in the repo. figlet,js is currently under the MIT license https://github.com/patorjk/figlet.js/blob/master/LICENSE.txt.
Fix missing possible end spacer on caca2tlf converted fonts. (final '@ ' on every char lines)
This reverts commit d9c1ba0.
Update test.yml python versions for github actions Rationale: one 2.7 version, the oldest 3.5, and the two most recent versions.
Not quite sure why, but it shows up in GitHub actions where we run from an egg.
importlib.resources was added in 3.7, so set that as the minimum Python 3 version.
Fixes font listing for non-zipped fonts
All zip fonts and some non-zip fonts fail to parse with this error:
e.g. for `ascii12`:
```
Traceback (most recent call last):
File "pyfiglet/__init__.py", line 349, in loadFont
width, letter = __char(data)
^^^^^^^^^^^^
File "pyfiglet/__init__.py", line 316, in __char
end = self.reEndMarker.search(line).group(1)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'group'
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.