Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather coverage data option. #7

Closed
sunshinejr opened this issue Jul 12, 2017 · 7 comments
Closed

Gather coverage data option. #7

sunshinejr opened this issue Jul 12, 2017 · 7 comments

Comments

@sunshinejr
Copy link

sunshinejr commented Jul 12, 2017

Hey @petester42. I'm wondering if you could introduce Gather coverage data option to the script. In #1169, we figured that now when you have this option selected in the main scheme, and you are using Xcode 9, the build won't pass the submission. Thus we would like to enable it only in MoyaTests scheme. Would it be possible? Or maybe you have another idea?

@pmairoldi
Copy link
Owner

Shouldn't be too hard. I'll look at what possible and come back to you. Isn't this just an Xcode 9 beta bug though?

@sunshinejr
Copy link
Author

Thank you! I'm not sure if this is a bug or a feature of Xcode 9 beta, but I came to a conclusion that we don't really need the coverage outside of MoyaTests anyways - what do you think about it?

@pmairoldi
Copy link
Owner

closed by #8

@akac
Copy link

akac commented Aug 17, 2017

I'm still having this issue myself - was this actually resolved for Xcode 9?

@pmairoldi
Copy link
Owner

It should be. I haven't tested publishing to the App Store but now by default the coverage data is off. Are you using 1.2.1?

@akac
Copy link

akac commented Aug 17, 2017

Well I just grabbed it yesterday - and my first TF build with Charts got called out for that. I opened the project and it was in the scheme. Its commit e72f28061eea69f6dcb1b684b709946f50c87610

@pmairoldi
Copy link
Owner

Well maybe it's not your project's fault. I don't think the charts project has been updated for Xcode 9 since I haven't merge #10 yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants