Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request / Spec] Adding TiDB specific resources #159

Closed
zph opened this issue Jun 27, 2024 · 2 comments
Closed

[Feature Request / Spec] Adding TiDB specific resources #159

zph opened this issue Jun 27, 2024 · 2 comments

Comments

@zph
Copy link

zph commented Jun 27, 2024

👋 Hi @petoju,

First off, thank you for the work you've put into maintaining this.

After contributing PR #158 and seeing that there are already files referencing TiDB, I'm wondering what your plans/design is for the project with regard to further extensions that support TiDB?

Specifically, I'm considering how to add and manage TiDB's Resource Controls and they're closely integrated with mysql users in TiDB. Resource Controls are declared via SQL and they're like dynamodb's Read Capacity Units or Write Capacity Units and allow for multi-tenancy of users while maintaining quality of service. link

Is that something you're interested to have contributed back to this project or do you prefer it live elsewhere?

@petoju
Copy link
Owner

petoju commented Jun 29, 2024

Hi @zph,

I'm wondering what your plans/design is for the project with regard to further extensions that support TiDB?

I have no plans at all. I'm maintaining this provider in my free time and my goal is working MySQL.
TiDB support is "best effort" - I don't really understand it, but I'm trying to keep it working as someone requested it.

Is that something you're interested to have contributed back to this project or do you prefer it live elsewhere?

I don't have strong opinions here. TiDB was added because someone didn't want to support own MySQL provider fork or alternative. If something is tested and doesn't break other code, I'm fine with merging it.

I can say I won't be here for large part of July, so if you are under time pressure, custom fork or alternative provider is the way to go.

@zph
Copy link
Author

zph commented Jun 29, 2024

@petoju Ok, thank you.

I think it's best for the community to contribute back to this as a main provider but I also know I'll want to contribute changes in July.

My plan is to upstream everything that I can back to here with testing/compatibility with other flavors of mysql and I'll keep a fork where I can move ahead temporarily while we agree on patches 👍

@zph zph closed this as completed Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants