Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url-encode unicode chars in source and target url #123

Closed
snarfed opened this issue Feb 28, 2017 · 2 comments
Closed

url-encode unicode chars in source and target url #123

snarfed opened this issue Feb 28, 2017 · 2 comments

Comments

@snarfed
Copy link
Contributor

snarfed commented Feb 28, 2017

sending a webmention with a unicode char in the source url failed recently, we think because it needs to be url-encoded. basically the same bug as aaronpk/Telegraph#16.

source: https://snarfed.org/2017-02-27_day-69-initial-editing-support-for-quill-100daysofindieweb-•-aaron-parecki
target: https://aaronparecki.com/2017/02/27/4/day-69-editing-in-quill

the webmention receiver (p3k) responded with HTTP 400 { "error": "invalid_request", "error_description": "source or target were invalid" }: https://telegraph.p3k.io/webmention/11UXLeTChJmz6hXsbk/details

@pfefferle
Copy link
Owner

The plugin send the correct data, so I think it's more a problem of Telegraph, or am I wrong?

ping @aaronpk

@aaronpk
Copy link
Contributor

aaronpk commented Mar 5, 2017

is not a URL-safe character. The plugin should be URL-encoding the for the source parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants