Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also use comment URL fragment for reply nesting? #463

Open
janboddez opened this issue Mar 20, 2024 · 1 comment
Open

Also use comment URL fragment for reply nesting? #463

janboddez opened this issue Mar 20, 2024 · 1 comment

Comments

@janboddez
Copy link
Contributor

janboddez commented Mar 20, 2024

I just published this reply to https://nicksimson.com/notes/941927cc48/#comment-782 (note the URL fragment), and noticed it didn't quite get "nested" correctly, at least not automatically.

It'd be nice, I guess, if the plugin took a guess and assumed this being in reply to another comment, and use the URL fragment to correctly nest the mention?

In IndieBlocks, I've attempted to do just that.

In Webmention, I noticed this bit of code that seems to store the fragment but not use it?

https://github.com/pfefferle/wordpress-webmention/blob/main/includes/class-receiver.php#L281-L298

Should I be using ?replytocom=<ID> instead? (I think we've discussed this before but I couldn't seem to find it back immediately.) Because that's not a URL that can readily be found. The "comment u-url" is the one with the fragment part, after all. (But I'm okay with adding the replytocom query argument as well, to improve compatibility.)

@pfefferle
Copy link
Owner

We discussed that for ActivityPub (which should not work because fragments are ignored by the server, so content negotiation wouldn't work), but I like the idea for Webmentions. Will work on an implementation!

Thanks for your report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants