Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition causes duplicate comments for same webmention source + target #474

Open
snarfed opened this issue May 20, 2024 · 1 comment
Open

Race condition causes duplicate comments for same webmention source + target #474

snarfed opened this issue May 20, 2024 · 1 comment

Comments

@snarfed
Copy link
Contributor

snarfed commented May 20, 2024

Hi @pfefferle, @dshanske! I got an interesting one just now: Bridgy Fed sent the same webmention (with same source and target) twice at almost the exact same time, within just ~10ms or so, and the plugin created two duplicate comments for it:

image

Looks like a race condition? I'm guessing you may want to add a lock or database transaction to prevent this.
@snarfed
Copy link
Contributor Author

snarfed commented May 20, 2024

cc snarfed/bridgy-fed#1063 (comment)

@dshanske dshanske mentioned this issue May 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snarfed