Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues are not propagated to github due to newlines #21

Closed
Limess opened this issue Jun 6, 2022 · 0 comments
Closed

Issues are not propagated to github due to newlines #21

Limess opened this issue Jun 6, 2022 · 0 comments

Comments

@Limess
Copy link
Contributor

Limess commented Jun 6, 2022

When testing this service we discovered a bug on Github where issues with newlines in titles do not get propagated to Slack when using the official Github Slack application (i.e. /github subscribe <org>/<repo> issues).

We've raised this with Github support, but this should be fixed in the library to prevent confusion - this is a result of the template creating a trailing newline in the issue, for example we were seeing this title in the request when using the default template:

"title":"[ALERT] alertname:TicketAlertTestV6 monitor:prometheus repo:data-platform-documentation severity:ticket system:system-monitoring \n"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant