-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We must unite syn
#1534
Comments
That is not currently my preference. I would prefer to keep dependencies locked down, preferably track the reasons for adding them, and deliberately induce friction to adding one.
Unfortunately, we have two different syns in this repo already. |
Also see #1504 for more events of deliberate, seemingly-fruitless duplication, and increased friction on adding dependencies. |
syn
We should fix the "have two |
Even if you do have multiple versions of sym, it would still be cleaner and easier to track if you use workspace for that. You can just give two different aliases to them in the main Cargo.toml. I have alleviated a lot of dep management pain this way, but obviously up to you. |
In my experience, it is usually better to consolidate all dependencies in the root
/Cargo.toml
, and use.workspace = true
everywhere else, even in cases where the dependency is used only in one project. The reason for this is it keeps everything in one place, all versions are consistent across all projects, and does not require refactoring when a dependency starts being used in more than one project.I will be happy to make this change if OK
The text was updated successfully, but these errors were encountered: