Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request/Issue - Don't lock child layers #30

Closed
megaroeny opened this issue Jan 11, 2022 · 3 comments
Closed

Request/Issue - Don't lock child layers #30

megaroeny opened this issue Jan 11, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@megaroeny
Copy link

megaroeny commented Jan 11, 2022

Problem

The issue with how you have it now, where some child layers/groups are locked, is if designers are moving objects around and want to include the spec measurements with those moves. I have to dig through all the layer groups and unlock them.

Improvements

  1. Simply just don't lock any child layers or groups in the "📐 Measurements" group you generate.
  2. Update the "refresh" button so it recognizes all measured objects new positions

Related enhancement

If refreshed, keep the different colors the user has set. For example, I like to use different colors for padding, spacing, and sizing:
image

@megaroeny megaroeny changed the title Request/Issue - Don Request/Issue - Don't lock child layers Jan 11, 2022
@ph1p ph1p added the enhancement New feature or request label Jan 11, 2022
@ph1p
Copy link
Owner

ph1p commented Jan 11, 2022

Hi @megaroeny thank you for reaching out! I'm currently working on a new version, where I try to make the whole layer handling better (including your suggestion :) ).

Likewise, updating the elements is part of it. Unfortunately, Figma can sometimes be the bottleneck here with too large files. I try to keep the plugin as performant as possible and avoid unnecessary iterations over elements. This is for example also the reason why there is a global group. I am also trying to improve this in the upcoming version.

@megaroeny
Copy link
Author

@ph1p cool sounds great! And no worries. Happy to hear it and good luck!

@ph1p ph1p closed this as completed in 4e4aaf2 Jan 11, 2022
@ph1p
Copy link
Owner

ph1p commented Jan 11, 2022

Found the "bug". Had written it in myself at the time ^^
I will now test it a bit and will let you know when I have it deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants