where is the problem?

[s-ohnishi]

I'm trying to get the sample application Invo ready for v5.
After changing a few things, I was able to log in, but when I searched, a fatal error occurred.
It seems that session_write_close() is involved, but I can't find any place to use it in Invo's source, and I can't find a clue to solve it.
Can anyone give me some hints on what to do?

The attached image has xDebug enabled for debugging in the IDE, but the situation is the same even if it is disabled, just changing to a simple message.

Phalcon: 5.1.3
PHP: 8.1.13

[s-ohnishi]

After investigating various things, the problem occurred when using the following Session\Bag ($this->persistent).
This was the same even after changing to Session.

           $query = Criteria::fromInput(
                $this->di,
                Companies::class,
                $this->request->getPost()
            );

            $this->persistent->searchParams = $query->getParams();

Exception: Serialization of 'Closure' is not allowed in [no active file] on line 0

And the error message "Serialization of 'Closure' is not allowed" means that Di is included in the array obtained by $query->getParams(), and Closure is included in the registered service etc. I think it's happening because it's there.

The sample application Invo plans to save the search conditions obtained through Criteria in the session bag and reuse them during pagination.
However, this attempt fails because "Serialization of 'Closure' is not allowed".

It may have been possible in some version of PHP, but it seems that serialization has not been possible for at least 9 years, so I feel that it is necessary to review the usage or design of Criteria.

Or is there some other solution?

[s-ohnishi]

As a workaround for the time being, the error disappeared when the di container part was deleted.
So far it seems to be working as expected, but I can't tell if it's the correct modification.

            $params = $query->getParams();
            unset($params['di']);
            $this->persistent->searchParams = $params;

or

            $this->persistent->searchParams = array('di'=>null) + $query->getParams();

[s-ohnishi]

Shouldn't Phalcon\Mvc\Model\Criteria::getParams() have an option that doesn't include closures that prevent serialization (i.e. doesn't return a di container)?