Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] Phalcon\Session\AdapterInterface::destroy() extra $session_id param #1108

Closed
anggiaj opened this issue Aug 18, 2013 · 3 comments
Closed

Comments

@anggiaj
Copy link

anggiaj commented Aug 18, 2013

It will be nice to have Phalcon\Session\AdapterInterface::destroy() compatible with
php SessionHandlerInterface::destroy(string $session_id) :D

Ex:

use Phalcon\Session\Adapter;
use Phalcon\Session\AdapterInterface;
use Phalcon\Session\Exception;


class MySessionAdapter extends Adapter implements AdapterInterface, SessionHandlerInterface
{
    public function __construct($options = null) 
    {
        session_set_save_handler($this, true);
    }

    // phalcon version
    // public function destroy(){}
    // session handler interface version
    // public function destroy($session_id){}
}

Note: tested under phalcon 1.2.3, php 5.4.x

CMIIW

@pgasiorowski
Copy link
Contributor

+1. This might be useful for functionality such as logging out someone else when we want to

  • swap current session adapter to something else
  • take application offline for maintenance
  • logout an user after suspicious activity

@ghost
Copy link

ghost commented Jan 12, 2014

PR submitted

@ghost
Copy link

ghost commented Jan 28, 2014

I guess this one can be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants